Document complex dtype limitation in ops.correlate #21984
Conversation
Summary of ChangesHello @PES2UG23CS205, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily intends to improve the clarity of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request appears to combine two unrelated changes. The main purpose, as described, is to document a limitation in keras.ops.correlate. However, the provided file changes only show the removal of NumPyTestRot90 from the excluded tests for the OpenVINO backend, which seems related to enabling rot90 tests. It is generally recommended to keep pull requests focused on a single logical change. I am unable to review the documentation change for correlate as the relevant file is not included in the provided patch. My review is therefore limited to the changes in keras/src/backend/openvino/excluded_concrete_tests.txt. In that file, I've noted that a blank line has been added at the beginning, which should be removed.
| NNOpsDynamicShapeTest::test_glu | ||
| NNOpsBehaviorTest::test_invalid_strategy_ctc_decode | ||
| NNOpsBehaviorTest::test_logit_recovery_binary_crossentropy | ||
There was a problem hiding this comment.
This change introduces a blank line at the beginning of the file. While this might not cause issues, it's generally better to avoid leading blank lines in configuration files like this to prevent potential parsing errors. Please remove the blank line.
hertschuh
left a comment
hertschuh
left a comment
There was a problem hiding this comment.
This change appears to change all carriage returns from Unix style to Windows style, thus showing every line changed:
https://github.com/keras-team/keras/pull/21984/changes
Can you revert the carriage returns?
| @@ -1,264 +1,271 @@ | |||
| NumPyTestRot90 | |||
|
Thanks for the review! You’re right , the previous version of this PR unintentionally included OpenVINO files due to CRLF line endings. |
|
Look here: https://github.com/keras-team/keras/pull/21984/changes The unwanted files are still present. |
| is discarded. | ||
| This behavior is documented for clarity and may change in the | ||
| future. See discussion in issue #21617. |
There was a problem hiding this comment.
Make it a link, it won't turn it to a link automatically:
[#21617](https://github.com/keras-team/keras/issues/21617)
There was a problem hiding this comment.
I’ve updated the inline documentation to link the discussion: #21617
PES2UG23CS205
force-pushed
the
docs-correlate-complex-note
branch
from
9b2ff7d to
dd548fe
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21984 +/- ##
========================================
Coverage 82.68% 82.69%
========================================
Files 588 592 +4
Lines 61491 62043 +552
Branches 9629 9718 +89
========================================
+ Hits 50846 51305 +459
- Misses 8152 8214 +62
- Partials 2493 2524 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for the review. |
google-ml-butler
bot
added
kokoro:force-run
ready to pull
|
Thank you so much for the review and for merging this PR! |
4 participants
This PR documents the current limitation of
keras.ops.correlatewith complexdtypes on the TensorFlow and PyTorch backends, where complex inputs are cast to
floating-point types and imaginary components are dropped.
This clarification aligns with the discussion in issue #21617.